RFC: Add incremental encaps API to support ML-KEM Braid#1619
RFC: Add incremental encaps API to support ML-KEM Braid#1619mkannwischer wants to merge 2 commits into
Conversation
325ab51 to
285fc8a
Compare
There was a problem hiding this comment.
Intel Xeon 4th gen (c7i)
Details
| Benchmark suite | Current: e9ea411 | Previous: 4482a37 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
11853 cycles |
11776 cycles |
1.01 |
ML-KEM-512 encaps |
13123 cycles |
13065 cycles |
1.00 |
ML-KEM-512 decaps |
17004 cycles |
17065 cycles |
1.00 |
ML-KEM-768 keypair |
19392 cycles |
19373 cycles |
1.00 |
ML-KEM-768 encaps |
20761 cycles |
20701 cycles |
1.00 |
ML-KEM-768 decaps |
26367 cycles |
26559 cycles |
0.99 |
ML-KEM-1024 keypair |
27984 cycles |
28108 cycles |
1.00 |
ML-KEM-1024 encaps |
30458 cycles |
30353 cycles |
1.00 |
ML-KEM-1024 decaps |
37829 cycles |
37481 cycles |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
ppc64le (POWER10) benchmarks
Details
| Benchmark suite | Current: e9ea411 | Previous: 4482a37 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
37821 cycles |
38203 cycles |
0.99 |
ML-KEM-512 encaps |
43056 cycles |
43487 cycles |
0.99 |
ML-KEM-512 decaps |
53357 cycles |
53659 cycles |
0.99 |
ML-KEM-768 keypair |
66725 cycles |
66779 cycles |
1.00 |
ML-KEM-768 encaps |
75736 cycles |
75888 cycles |
1.00 |
ML-KEM-768 decaps |
89918 cycles |
90189 cycles |
1.00 |
ML-KEM-1024 keypair |
108567 cycles |
114656 cycles |
0.95 |
ML-KEM-1024 encaps |
118737 cycles |
125597 cycles |
0.95 |
ML-KEM-1024 decaps |
137142 cycles |
144918 cycles |
0.95 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
AMD EPYC 3rd gen (c6a)
Details
| Benchmark suite | Current: e9ea411 | Previous: 4482a37 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
14465 cycles |
14441 cycles |
1.00 |
ML-KEM-512 encaps |
15942 cycles |
15934 cycles |
1.00 |
ML-KEM-512 decaps |
21395 cycles |
21336 cycles |
1.00 |
ML-KEM-768 keypair |
23773 cycles |
23760 cycles |
1.00 |
ML-KEM-768 encaps |
25115 cycles |
25216 cycles |
1.00 |
ML-KEM-768 decaps |
33011 cycles |
32943 cycles |
1.00 |
ML-KEM-1024 keypair |
33471 cycles |
33378 cycles |
1.00 |
ML-KEM-1024 encaps |
35824 cycles |
35867 cycles |
1.00 |
ML-KEM-1024 decaps |
46179 cycles |
46149 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'AMD EPYC 3rd gen (c6a)'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.03.
| Benchmark suite | Current: a4e4e31 | Previous: 2bf8e59 | Ratio |
|---|---|---|---|
ML-KEM-512 encaps |
16707 cycles |
15974 cycles |
1.05 |
ML-KEM-768 decaps |
35711 cycles |
33345 cycles |
1.07 |
ML-KEM-1024 decaps |
50650 cycles |
46735 cycles |
1.08 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Intel Xeon 4th gen (c7i) (no-opt)
Details
| Benchmark suite | Current: e9ea411 | Previous: 4482a37 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
27685 cycles |
27661 cycles |
1.00 |
ML-KEM-512 encaps |
34281 cycles |
35679 cycles |
0.96 |
ML-KEM-512 decaps |
43870 cycles |
44306 cycles |
0.99 |
ML-KEM-768 keypair |
44503 cycles |
44223 cycles |
1.01 |
ML-KEM-768 encaps |
54127 cycles |
55144 cycles |
0.98 |
ML-KEM-768 decaps |
66760 cycles |
68201 cycles |
0.98 |
ML-KEM-1024 keypair |
68040 cycles |
67847 cycles |
1.00 |
ML-KEM-1024 encaps |
80112 cycles |
78956 cycles |
1.01 |
ML-KEM-1024 decaps |
97058 cycles |
96217 cycles |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
AMD EPYC 4th gen (c7a)
Details
| Benchmark suite | Current: e9ea411 | Previous: 4482a37 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
12825 cycles |
12868 cycles |
1.00 |
ML-KEM-512 encaps |
14241 cycles |
14232 cycles |
1.00 |
ML-KEM-512 decaps |
18988 cycles |
18980 cycles |
1.00 |
ML-KEM-768 keypair |
21586 cycles |
21563 cycles |
1.00 |
ML-KEM-768 encaps |
22718 cycles |
22720 cycles |
1.00 |
ML-KEM-768 decaps |
29794 cycles |
29740 cycles |
1.00 |
ML-KEM-1024 keypair |
30629 cycles |
30507 cycles |
1.00 |
ML-KEM-1024 encaps |
32695 cycles |
32653 cycles |
1.00 |
ML-KEM-1024 decaps |
41956 cycles |
41954 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'AMD EPYC 4th gen (c7a)'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.03.
| Benchmark suite | Current: a4e4e31 | Previous: 2bf8e59 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
13236 cycles |
12779 cycles |
1.04 |
ML-KEM-512 encaps |
15642 cycles |
14273 cycles |
1.10 |
ML-KEM-768 decaps |
32957 cycles |
30058 cycles |
1.10 |
ML-KEM-1024 keypair |
34340 cycles |
32987 cycles |
1.04 |
ML-KEM-1024 decaps |
47071 cycles |
42393 cycles |
1.11 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Intel Xeon 3rd gen (c6i)
Details
| Benchmark suite | Current: e9ea411 | Previous: 4482a37 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
17921 cycles |
17866 cycles |
1.00 |
ML-KEM-512 encaps |
20012 cycles |
20054 cycles |
1.00 |
ML-KEM-512 decaps |
26695 cycles |
26609 cycles |
1.00 |
ML-KEM-768 keypair |
32510 cycles |
29935 cycles |
1.09 |
ML-KEM-768 encaps |
31503 cycles |
32680 cycles |
0.96 |
ML-KEM-768 decaps |
41528 cycles |
41409 cycles |
1.00 |
ML-KEM-1024 keypair |
42162 cycles |
42984 cycles |
0.98 |
ML-KEM-1024 encaps |
46821 cycles |
45073 cycles |
1.04 |
ML-KEM-1024 decaps |
60681 cycles |
58039 cycles |
1.05 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Intel Xeon 3rd gen (c6i)'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.03.
| Benchmark suite | Current: e9ea411 | Previous: 4482a37 | Ratio |
|---|---|---|---|
ML-KEM-768 keypair |
32510 cycles |
29935 cycles |
1.09 |
ML-KEM-1024 encaps |
46821 cycles |
45073 cycles |
1.04 |
ML-KEM-1024 decaps |
60681 cycles |
58039 cycles |
1.05 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
AMD EPYC 3rd gen (c6a) (no-opt)
Details
| Benchmark suite | Current: e9ea411 | Previous: 4482a37 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
40201 cycles |
40213 cycles |
1.00 |
ML-KEM-512 encaps |
48542 cycles |
48370 cycles |
1.00 |
ML-KEM-512 decaps |
62176 cycles |
62174 cycles |
1.00 |
ML-KEM-768 keypair |
62641 cycles |
62566 cycles |
1.00 |
ML-KEM-768 encaps |
74682 cycles |
74803 cycles |
1.00 |
ML-KEM-768 decaps |
92226 cycles |
92304 cycles |
1.00 |
ML-KEM-1024 keypair |
94939 cycles |
95014 cycles |
1.00 |
ML-KEM-1024 encaps |
109951 cycles |
110210 cycles |
1.00 |
ML-KEM-1024 decaps |
132335 cycles |
132320 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
AMD EPYC 4th gen (c7a) (no-opt)
Details
| Benchmark suite | Current: e9ea411 | Previous: 4482a37 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
36774 cycles |
36792 cycles |
1.00 |
ML-KEM-512 encaps |
42794 cycles |
42829 cycles |
1.00 |
ML-KEM-512 decaps |
55540 cycles |
55590 cycles |
1.00 |
ML-KEM-768 keypair |
57956 cycles |
58040 cycles |
1.00 |
ML-KEM-768 encaps |
66815 cycles |
66873 cycles |
1.00 |
ML-KEM-768 decaps |
83502 cycles |
83563 cycles |
1.00 |
ML-KEM-1024 keypair |
88561 cycles |
88564 cycles |
1.00 |
ML-KEM-1024 encaps |
99020 cycles |
99066 cycles |
1.00 |
ML-KEM-1024 decaps |
120497 cycles |
120649 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Arm Cortex-A76 (Raspberry Pi 5) benchmarks
Details
| Benchmark suite | Current: e9ea411 | Previous: 4482a37 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
28243 cycles |
28235 cycles |
1.00 |
ML-KEM-512 encaps |
34131 cycles |
34092 cycles |
1.00 |
ML-KEM-512 decaps |
44543 cycles |
44505 cycles |
1.00 |
ML-KEM-768 keypair |
47617 cycles |
47612 cycles |
1.00 |
ML-KEM-768 encaps |
53735 cycles |
53774 cycles |
1.00 |
ML-KEM-768 decaps |
68350 cycles |
68448 cycles |
1.00 |
ML-KEM-1024 keypair |
70247 cycles |
70164 cycles |
1.00 |
ML-KEM-1024 encaps |
78545 cycles |
78671 cycles |
1.00 |
ML-KEM-1024 decaps |
98249 cycles |
98323 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Graviton4
Details
| Benchmark suite | Current: e9ea411 | Previous: b13df87 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
17672 cycles |
17688 cycles |
1.00 |
ML-KEM-512 encaps |
20575 cycles |
20580 cycles |
1.00 |
ML-KEM-512 decaps |
27019 cycles |
27041 cycles |
1.00 |
ML-KEM-768 keypair |
29855 cycles |
29884 cycles |
1.00 |
ML-KEM-768 encaps |
32645 cycles |
32622 cycles |
1.00 |
ML-KEM-768 decaps |
41842 cycles |
41908 cycles |
1.00 |
ML-KEM-1024 keypair |
43752 cycles |
43719 cycles |
1.00 |
ML-KEM-1024 encaps |
48716 cycles |
48697 cycles |
1.00 |
ML-KEM-1024 decaps |
61322 cycles |
61364 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Intel Xeon 3rd gen (c6i) (no-opt)
Details
| Benchmark suite | Current: e9ea411 | Previous: 4482a37 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
47333 cycles |
46788 cycles |
1.01 |
ML-KEM-512 encaps |
55761 cycles |
55610 cycles |
1.00 |
ML-KEM-512 decaps |
71489 cycles |
71256 cycles |
1.00 |
ML-KEM-768 keypair |
73869 cycles |
74467 cycles |
0.99 |
ML-KEM-768 encaps |
86607 cycles |
86021 cycles |
1.01 |
ML-KEM-768 decaps |
107279 cycles |
107222 cycles |
1.00 |
ML-KEM-1024 keypair |
111424 cycles |
111541 cycles |
1.00 |
ML-KEM-1024 encaps |
126627 cycles |
126103 cycles |
1.00 |
ML-KEM-1024 decaps |
152476 cycles |
152172 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Graviton4 (no-opt)
Details
| Benchmark suite | Current: e9ea411 | Previous: b13df87 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
35229 cycles |
35280 cycles |
1.00 |
ML-KEM-512 encaps |
39983 cycles |
40023 cycles |
1.00 |
ML-KEM-512 decaps |
50731 cycles |
50626 cycles |
1.00 |
ML-KEM-768 keypair |
56685 cycles |
56804 cycles |
1.00 |
ML-KEM-768 encaps |
63645 cycles |
64047 cycles |
0.99 |
ML-KEM-768 decaps |
78117 cycles |
78489 cycles |
1.00 |
ML-KEM-1024 keypair |
87304 cycles |
87373 cycles |
1.00 |
ML-KEM-1024 encaps |
97083 cycles |
96672 cycles |
1.00 |
ML-KEM-1024 decaps |
115151 cycles |
114712 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Graviton3
Details
| Benchmark suite | Current: e9ea411 | Previous: b13df87 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
18670 cycles |
18678 cycles |
1.00 |
ML-KEM-512 encaps |
21800 cycles |
21864 cycles |
1.00 |
ML-KEM-512 decaps |
28786 cycles |
28823 cycles |
1.00 |
ML-KEM-768 keypair |
31528 cycles |
31567 cycles |
1.00 |
ML-KEM-768 encaps |
34667 cycles |
34683 cycles |
1.00 |
ML-KEM-768 decaps |
44698 cycles |
44777 cycles |
1.00 |
ML-KEM-1024 keypair |
46196 cycles |
46125 cycles |
1.00 |
ML-KEM-1024 encaps |
51503 cycles |
51493 cycles |
1.00 |
ML-KEM-1024 decaps |
64986 cycles |
64964 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Graviton2
Details
| Benchmark suite | Current: e9ea411 | Previous: b13df87 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
28204 cycles |
28236 cycles |
1.00 |
ML-KEM-512 encaps |
34133 cycles |
34084 cycles |
1.00 |
ML-KEM-512 decaps |
44506 cycles |
44432 cycles |
1.00 |
ML-KEM-768 keypair |
47615 cycles |
47625 cycles |
1.00 |
ML-KEM-768 encaps |
53749 cycles |
53803 cycles |
1.00 |
ML-KEM-768 decaps |
68333 cycles |
68517 cycles |
1.00 |
ML-KEM-1024 keypair |
70167 cycles |
70259 cycles |
1.00 |
ML-KEM-1024 encaps |
78556 cycles |
78648 cycles |
1.00 |
ML-KEM-1024 decaps |
98212 cycles |
98319 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Graviton3 (no-opt)
Details
| Benchmark suite | Current: e9ea411 | Previous: b13df87 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
38828 cycles |
38908 cycles |
1.00 |
ML-KEM-512 encaps |
44405 cycles |
44381 cycles |
1.00 |
ML-KEM-512 decaps |
56276 cycles |
56214 cycles |
1.00 |
ML-KEM-768 keypair |
62258 cycles |
62498 cycles |
1.00 |
ML-KEM-768 encaps |
70243 cycles |
70439 cycles |
1.00 |
ML-KEM-768 decaps |
86192 cycles |
86364 cycles |
1.00 |
ML-KEM-1024 keypair |
95777 cycles |
95880 cycles |
1.00 |
ML-KEM-1024 encaps |
106465 cycles |
106092 cycles |
1.00 |
ML-KEM-1024 decaps |
126189 cycles |
125748 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Graviton2 (no-opt)
Details
| Benchmark suite | Current: e9ea411 | Previous: b13df87 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
58745 cycles |
58742 cycles |
1.00 |
ML-KEM-512 encaps |
68587 cycles |
68447 cycles |
1.00 |
ML-KEM-512 decaps |
87502 cycles |
87352 cycles |
1.00 |
ML-KEM-768 keypair |
94987 cycles |
94443 cycles |
1.01 |
ML-KEM-768 encaps |
109213 cycles |
108796 cycles |
1.00 |
ML-KEM-768 decaps |
134323 cycles |
133769 cycles |
1.00 |
ML-KEM-1024 keypair |
151089 cycles |
150776 cycles |
1.00 |
ML-KEM-1024 encaps |
165508 cycles |
165506 cycles |
1.00 |
ML-KEM-1024 decaps |
198873 cycles |
198660 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
CBMC Results (ML-KEM-512)Full Results (198 proofs)
|
CBMC Results (ML-KEM-768)Full Results (198 proofs)
|
CBMC Results (ML-KEM-1024)
Full Results (198 proofs)
|
hanno-becker
left a comment
There was a problem hiding this comment.
What's the purpose of 0a01cc4? Tests also serve as documentation, and using internal constants rather than public ones sets a wrong example.
If this is needed, can it be done in a preparatory PR? It seems unrelated to this PR.
The main question here is if we want to add the new API in mlkem_native.h or not. If we don't, we can't test the API in the standard test_mlkem.c, but we could add it in a separate test that includes kem.h, but not mlkem_native.h. I agree with you that we don't want to keep it as is right now. |
|
Seeing that you also observed a slowdown on x86, I wonder if we should treat the incremental API as internal by default and only expose it in the public API if some new option |
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Intel Xeon 4th gen (c7i)'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.03.
| Benchmark suite | Current: a4e4e31 | Previous: 2bf8e59 | Ratio |
|---|---|---|---|
ML-KEM-1024 decaps |
40620 cycles |
39396 cycles |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
4f0ace1 to
732adb5
Compare
There was a problem hiding this comment.
Mac Mini (M1, 2020) benchmarks
Details
| Benchmark suite | Current: e9ea411 | Previous: 4482a37 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
12318 cycles |
12320 cycles |
1.00 |
ML-KEM-512 encaps |
14811 cycles |
14763 cycles |
1.00 |
ML-KEM-512 decaps |
19363 cycles |
19318 cycles |
1.00 |
ML-KEM-768 keypair |
21268 cycles |
21269 cycles |
1.00 |
ML-KEM-768 encaps |
23524 cycles |
23513 cycles |
1.00 |
ML-KEM-768 decaps |
30069 cycles |
30057 cycles |
1.00 |
ML-KEM-1024 keypair |
30332 cycles |
30328 cycles |
1.00 |
ML-KEM-1024 encaps |
34141 cycles |
34094 cycles |
1.00 |
ML-KEM-1024 decaps |
43755 cycles |
43708 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Arm Cortex-A55 (Snapdragon 888) benchmarks
Details
| Benchmark suite | Current: e9ea411 | Previous: 4482a37 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
59809 cycles |
59789 cycles |
1.00 |
ML-KEM-512 encaps |
67442 cycles |
67420 cycles |
1.00 |
ML-KEM-512 decaps |
86474 cycles |
86424 cycles |
1.00 |
ML-KEM-768 keypair |
97438 cycles |
97457 cycles |
1.00 |
ML-KEM-768 encaps |
110852 cycles |
110756 cycles |
1.00 |
ML-KEM-768 decaps |
137951 cycles |
138252 cycles |
1.00 |
ML-KEM-1024 keypair |
154756 cycles |
154707 cycles |
1.00 |
ML-KEM-1024 encaps |
171127 cycles |
171167 cycles |
1.00 |
ML-KEM-1024 decaps |
207595 cycles |
207712 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Arm Cortex-A72 (Raspberry Pi 4) benchmarks
Details
| Benchmark suite | Current: e9ea411 | Previous: 4482a37 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
51223 cycles |
50942 cycles |
1.01 |
ML-KEM-512 encaps |
59000 cycles |
58869 cycles |
1.00 |
ML-KEM-512 decaps |
75420 cycles |
74924 cycles |
1.01 |
ML-KEM-768 keypair |
86737 cycles |
85776 cycles |
1.01 |
ML-KEM-768 encaps |
95064 cycles |
93464 cycles |
1.02 |
ML-KEM-768 decaps |
118094 cycles |
117436 cycles |
1.01 |
ML-KEM-1024 keypair |
130563 cycles |
129378 cycles |
1.01 |
ML-KEM-1024 encaps |
143127 cycles |
141713 cycles |
1.01 |
ML-KEM-1024 decaps |
174056 cycles |
174402 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
SpacemiT K1 8 (Banana Pi F3) benchmarks
Details
| Benchmark suite | Current: e9ea411 | Previous: 4482a37 | Ratio |
|---|---|---|---|
ML-KEM-512 keypair |
143044 cycles |
143036 cycles |
1.00 |
ML-KEM-512 encaps |
151348 cycles |
151397 cycles |
1.00 |
ML-KEM-512 decaps |
189670 cycles |
189743 cycles |
1.00 |
ML-KEM-768 keypair |
233070 cycles |
233084 cycles |
1.00 |
ML-KEM-768 encaps |
250095 cycles |
250290 cycles |
1.00 |
ML-KEM-768 decaps |
304725 cycles |
304913 cycles |
1.00 |
ML-KEM-1024 keypair |
365594 cycles |
365632 cycles |
1.00 |
ML-KEM-1024 encaps |
387752 cycles |
388994 cycles |
1.00 |
ML-KEM-1024 decaps |
457640 cycles |
459309 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
1ce787b to
a4e4e31
Compare
a4e4e31 to
856b540
Compare
ab8f4bf to
37d5620
Compare
d488734 to
a51ea38
Compare
Split K-PKE.Encrypt and ML-KEM.Encaps into two phases (u and v) to support protocols like MLKEMBraid that transmit large KEM components in parallel over bandwidth-constrained channels. CPA level (indcpa): - mlk_indcpa_enc_u: computes ct_u from ek_seed, outputs intermediate state (sp, epp, sp_cache) - mlk_indcpa_enc_v: computes ct_v from ek_vector using intermediate state from enc_u CCA KEM level (kem): - mlk_kem_enc_derand_u: FO transform + enc_u, outputs shared secret and intermediate state; only needs ek_seed and H(pk) - mlk_kem_enc_v: modulus check on ek_vector + enc_v; only needs ek_vector epp is serialized as 4-bit nibbles (ETA2 - x) to provide a natural coefficient bound on deserialization; sp is serialized as 16-bit LE. The shared sp mulcache is computed once and threaded through enc_u/enc_v. Includes CBMC contracts and proofs for the new functions, the MLK_CONFIG_ENABLE_MLKEM_BRAID configuration option exposing the API, recomputed peak stack consumption values, and OpenTitan work buffer size updates. The test verifies that the incremental API produces identical ciphertexts and shared secrets as the standard API across all three parameter sets. Co-authored-by: Hanno Becker <beckphan@amazon.co.uk> Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com> Signed-off-by: Rod Chapman <rodchap@amazon.com>
Signed-off-by: Rod Chapman <rodchap@amazon.com>
a1672a8 to
e9ea411
Compare
Split ML-KEM encapsulation into two phases (mlk_kem_enc_derand_u / mlk_kem_enc_v) to support protocols like Braid that need to interleave encapsulation with other operations between computing the u- and v-components of the ciphertext. The first phase only requires the public seed and H(pk), not the full public key vector. Internally, K-PKE.Encrypt is refactored into mlk_indcpa_enc_u + mlk_indcpa_enc_v. The non-incremental KEM path calls mlk_indcpa_enc directly to avoid serialization overhead. The intermediate noise polynomial epp is serialized as 4-bit nibbles (128 bytes) - this is primarily done to not require a pre-condition on the allowed values.